test/16-board-manager-unit-tests | Unit Tests und Refactoring #20

Merged

FlorianReetz merged 18 commits from test/16-board-manager-unit-tests into dev 2026-02-04 17:20:53 +00:00

Conversation 1 Commits 18 Files changed 232 +21063 -86

FlorianReetz commented 2026-02-04 17:16:55 +00:00

Owner

Copy link

GUT Test Suite importiert, Unit Tests für alle bestehenden Klassen/Szenen geschrieben, Notwendigkeit des Refactoring beim Verfassend er nit Tests entdeckt, BoardArray Klasse eingeführt.

GUT Test Suite importiert, Unit Tests für alle bestehenden Klassen/Szenen geschrieben, Notwendigkeit des Refactoring beim Verfassend er nit Tests entdeckt, BoardArray Klasse eingeführt.

FlorianReetz added this to the Wiederherstellung Prototype in Godot milestone 2026-02-04 17:16:55 +00:00

FlorianReetz added 18 commits 2026-02-04 17:16:56 +00:00

Imported GUT Plugin ca6e998d62

Added Unit Tests for tile.gd and board_layout.gd ca6c4a19bf

Cleaned Up tile.gd to no longer reference own children, adjusted test_tile.gd to no longer set up mock scene graph. 68fa8115e9

Added BoardArray class cfaf18a6e2

Cleaned Up BoardArray. Documented BoardArray. 5dacd1137d

Implemented new BoardArray class into BoardLayout. ddb26a67ce

Implemented BoardArray into BoardManager class. 35ba0b4517

Updated Unit-Test for test_board_layout.gd 0346b319ec

Added fore_each_cell function to BoardArray. b188d88856

Implemented new clear_board function, using new for_each method from BoardArray. af72d1852a

Modified build_board to spawn_from_layout method, using the new BoardArray iteration API. c5ebc8749d

Made get_cell static return type int. 30f4934179

Reverted changes. f3f562fc43

Introduced try_get_cell method for dynamic access and testing. d64c90e026

Cleaned Up tests. 997030ace1

Modified BoardManager to fit test critera, discoverd bei TDD. Added Unit Tests for BoardManager class. Not yet finished. 92e2b816a3

Changed onready var to var assignedment during _ready(). No more editor errors du to unassigned onready var. 8f4beb99da

Finalized BoardManager Unit Tests. b1ef70a223

FlorianReetz added this to the MamaMahjong Development Board project 2026-02-04 17:16:56 +00:00

FlorianReetz commented 2026-02-04 17:18:34 +00:00

Author

Owner

Copy link

• Unit Tests : all green
• Keine Warnings, keine Errors im Editor
• Code Review abgeschlossen
• Akzeptanzkriterien erfüllt

closes #16 und #17

- [x] Unit Tests : all green - [x] Keine Warnings, keine Errors im Editor - [x] Code Review abgeschlossen - [x] Akzeptanzkriterien erfüllt closes #16 und #17

FlorianReetz merged commit 3e0e72b2c6 into dev 2026-02-04 17:20:53 +00:00

FlorianReetz deleted branch test/16-board-manager-unit-tests 2026-02-04 17:20:53 +00:00

FlorianReetz referenced this pull request from a commit 2026-02-04 17:20:54 +00:00

Merge pull request 'test/16-board-manager-unit-tests | Unit Tests und Refactoring' (#20) from test/16-board-manager-unit-tests into dev

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

1| type: bug

bug found. open new issue with this label

  

1| type: documentation

flags a task as documental work

  

1| type: feature

new experience-relevant addition to the project

  

1| type: fix

not a bug but an adjustment request within the games parameters

  

1| type: refactor

overhaul of legacy code

  

1| type: spike

analytical task, decision making, follow up tasks

  

1| type: tech-debt

optimizing system, not refactoring, but technical overhaul

  

2| prio: critical

show stopper, blocks other tasks, core systems affected, build not executable

  

2| prio: high

relevant to current milestone, contribution to customer experience

  

2| prio: low

cosmetical tasks, qol tasks, optimization tasks, can be delayed

  

2| prio: medium

important but no blocker, can be delayed in favour of other tasks

  

3| diff: complex

task requires architectual decisions, multiple dependencies, requires iterations

  

3| diff: exploratory

task is open to definition, needs prototype (own branch), technical or architectual risks

  

3| diff: standard

task is defined, needs integration, known patterns, lokal dependencies

  

3| diff: trivial

task is well defined, low dependencies, no risks (creating a scene, adding a lable, changes in config)

  

4| area: animation

animation work

  

4| area: art

new asset production or integration

  

4| area: audio

audio asset production or integration

  

4| area: gameplay

new gameplay relevant feature

  

4| area: tech

technical or architectual issue

  

4| area: ui / ux

ui or ux relevant task

  

9| extra: blocked

mark a task with this label if it is blocked by another issue

No labels

1| type: bug

1| type: documentation

1| type: feature

1| type: fix

1| type: refactor

1| type: spike

1| type: tech-debt

2| prio: critical

2| prio: high

2| prio: low

2| prio: medium

3| diff: complex

3| diff: exploratory

3| diff: standard

3| diff: trivial

4| area: animation

4| area: art

4| area: audio

4| area: gameplay

4| area: tech

4| area: ui / ux

9| extra: blocked

Milestone

Clear milestone

No items

No milestone

Wiederherstellung Prototype in Godot

Projects

Clear projects

No items

No project

MamaMahjong Development Board

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Headframe_Studio/MamaMahjong!20

No description provided.